> I have drafted a new change based on a new method > Federation.IsNewTopicWritable() > using overloads of HasPermission(NamespaceManager, TopicPermission). > > I want to create test cases for the implementations of HasPermission. > It looks like I have not broken any existing cases, even the one for > new topics, due to the use of the overload. I think I need to add a > ReadOnly MockDirectory creation method and an implementation of > HasPermission in MockContentStore that matches the overload. > > Does this seem reasonable?
Creating Federation.IsNewTopicWritable seems like a reasonable thing to do, although Federation is such a god-awful mess that adding new methods to it makes me cringe. But I don't think there's anything you can do about that without tackling a pretty big refactor. Looking at the code, I remember that AuthorizationProvider already returns the right answer for nonexistent topics. So where is the problem coming from in the web UI? I.e. what is it about the current scheme that's screwing things up? ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Flexwiki-users mailing list Flexwiki-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flexwiki-users
