> > -string ConvertRwyNumToSpokenString(string s) {
> > +string ConvertRwyNumToSpokenString(const string s) {
>
> this should be string ConvertRwyNumToSpokenString(const string& s)
> so we don't make unnecessary copies.
>
> > -double dclGetHorizontalSeparation(Point3D pos1, Point3D pos2) {
> > +double dclGetHorizontalSeparation(const Point3D pos1, const Point3D pos2) {
>
> same: const Point3D& pos1, const Point3D& pos2I fully agree with your proposal. > all the functions are making unnecessary copies instead of passing by > reference. i've changed a lot of these for my local copy, so i can > submit a patch if there is interest. Surely that's a beneficial change, so please submit, whether you're talking about just the ATCutils module cleanup or of something with a wider scope. V. _______________________________________________ Flightgear-devel mailing list [email protected] http://mail.flightgear.org/mailman/listinfo/flightgear-devel 2f585eeea02e2c79d7b1d8c4963bae2d
