Vassilii Khachaturov wrote:
http://caliban.lbl.gov/fgfs_patches/flightgear.diff


Great work. I wonder if there is a way to profile fg/sg for this kind
of inefficiencies somewhere in a tight loop.

Ok, these changes have been committed. It's quite extensive but I'm rather pleased with them. Thanks Alex!

A couple of comments:

-    inline Point3D GetPos() { return(pos); }
+    inline const Point3D& GetPos() { return(pos); }

If you return the pos as a const Point3D&, you should
probably mark the method to be const as well on the same occasion.

This one has been omitted because it limits it's usability and doesn't improve the code much IMHO.

This one looks to me as containing some additional local changes you've
made, beyond the const& optimization. See the chunks pertaining to

simgear/math/point3d.hxx
simgear/math/polar3d.hxx
and simgear/threads/SGThread.hxx

These are all speedups and thread safety updates, so I've committed these also.

Erik

_______________________________________________
Flightgear-devel mailing list
[email protected]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
2f585eeea02e2c79d7b1d8c4963bae2d

Reply via email to