Hi Vassilii, it is indeed an debugging artifact. At least the "using namespace std" is. The rest was existing code. I'll see what I can change. As for the vector math, I didn't change any of that and this is all from the original implementation. And I don't really want to fuzz with that.
Mark Vassilii Khachaturov wrote: >> http://www.akermann.org/fgfs/simgear-sun.tar.gz >> > The chunk > @@ -109,6 +109,7 @@ void SGSky::build( double h_radius_m, do > // 180 degrees = darkest midnight > bool SGSky::repaint( const SGSkyColor &sc ) > { > + using namespace std; > if ( effective_visibility > 1000.0 ) { > enable(); > dome->repaint( sc.sky_color, sc.fog_color, sc.sun_angle, > seems a debugging artifact to me. > > In "oursun.cxx" the constants (such as sqrt_m_log01) should probably be > declared as const. Per-coordinate vector calculations there could be > made to use the sg facilities of plib, but AFAIU it wouldn't change > much except for shorten the code a tiny bit. It's pretty readable as it is > anyhow, and fits in very nicely. Also, a patch to "Thanks" is due along > with the commit, to mention yourself :) > > Thank you very much!!! > > Vassilii > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys -- and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Flightgear-devel mailing list > Flightgear-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/flightgear-devel > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
