On 03/03/2007 12:32 PM, Melchior FRANZ wrote:
> hxx:
> + virtual void Init();
> cxx:
> +void FGATC::Init() {
> +// This should never be called, since each derived class will have its
> own
> +// Init() that overrides this one.
> +}
>
> So, why are you adding it?!
Perhaps because the code wouldn't be correct without it?!
> Don't use cout/cerr. Use SG_LOG with appropriate log levels.
There are 2017 comparable uses of cout in FlightGear and 376 more
in SimGear. Why don't you remove some of those? When it gets
down to the point where the ones I've put in are, say, 1% of the
total, I'll consider removing them.
> atis.cxx is *exclusively* tab indented. .... Applying this patch would
> mess up the whole file.
Here's a measure of how big a mess we're talking about: When I changed
the indentation just now, to make it more uniform, it increased the
length of the atis.?xx patch from 474 to 487 lines. That's almost
three percent!
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
