On 6/14/07, Martin Spott <[EMAIL PROTECTED]> wrote: > "Vivian Meazza" wrote: > > > Lesson for the future. Understand what code does, test that it doesn't break > > anything, make sure it compiles on at least one other os, and submit it for > > review (especially when you are mucking around with other people's code). > [...] > > I don't enjoy repairing code which other people break, and nor, I expect > > does Alexis. I haven't got time, nor the inclination. > > Did you make sure that you're targetting the right person? Just in case > you didn't know, then you should realize _now_ that you're not the only > person who's been working on the AI subsystem recently.
Looks like tacan is the magic word to make Vivian mad ;) Some time ago I also submitted a tacan patch for review, didn't get much response from other people. Might be worth to check it out if somebody missed it and is interested. I think my ideas were not that bad for the future. The "if it ain't broke don't fix it" strategy is not always the best. Now to the coding style. I can probably adjust to any style adopted as standard, but pretty please forget about using spaces for indentation. Isn't it obvious, that indentation is a higher level abstraction and thus should be indicated in other ways (meaning tabs, of course)? Besides, I can't imagine anyone counting the 12 spaces for the 3rd indentation level. I assume they would just press tab and their editors would do the rest. But then you can configure almost any editor to display tabs in whatever size you are comfortable with. I can't see any drawbacks in this. Finally some words about development in general. Of course everybody should test their changes prior to submitting them for inclusion, but I don't think this is such a serious matter. (Certainly not warranting buying a copy of windows to be able to check cross-platform) If any problems come up later, I am sure the author of the patch would be willing to fix what he has broken. As a last resort, the offending patch could be reverted, nothing is lost. Nobody is required to fix stuff broken by others. Some bad-tempered mail started showing up on this list recently. For me flightgear is great fun both flying and coding and I intend to keep it that way. So everybody be nice and don't get mad at each other, okay? Greets, Csaba PS: Be on the lookout, AWACS reports some patches on the way from me ;) ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
