Martin 

> Behalf Of Spott
> Sent: 13 June 2007 23:58
> To: flightgear-devel@lists.sourceforge.net
> Subject: Re: [Flightgear-devel] C++ code beautifier / Coding
> 
> 
> "Vivian Meazza" wrote:
> 
> > Lesson for the future. Understand what code does, test that 
> it doesn't 
> > break anything, make sure it compiles on at least one other os, and 
> > submit it for review (especially when you are mucking around with 
> > other people's code).
> [...]
> > I don't enjoy repairing code which other people break, and nor, I 
> > expect does Alexis. I haven't got time, nor the inclination.
> 
> Did you make sure that you're targetting the right person? 
> Just in case you didn't know, then you should realize _now_ 
> that you're not the only person who's been working on the AI 
> subsystem recently.

That's exactly the point - I am the author of much the code affected
directly or indirectly by this code, not to mention the ac models which use
it. I was unwire of any problem that need fixing, nor of any activity. It
would have been nice to have been so.
 
> BTW, breaking the build on other people's platforms is, 
> unfortunately, common practice in FlightGear development and 
> it's a rare case that those who broke it take care for 
> getting things right within the next few days. In this 
> context I don't think it's adequate to exaggerate the whole story,

That's normal in the run up to a release is it? I don't think so. I take the
precaution to ensure that my patches at least compile on one flavour of
Linux, and on MSVC8. It's not rocket science. That a patch doesn't is
indicative of inadequate testing. Just because it is common practice,
doesn't mean that it is good practice. 

I'm not even clear that I have the time to test MP-AAR, let alone the method
of fixing it, if indeed it is broken.

Vivian 



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to