Am Dienstag 03 Juli 2007 10:28 schrieb Vivian Meazza: > Of course code breakage happens. But in an ideal world, it shouldn't get > into cvs.
In an ideal world we had automated unit test that cover everything... Welcome to reality :-P > It makes us all look unprofessional. Not more than not having proper release management. > Proper peer review can help > prevent this. At least it gives others, perhaps more expert than us a > chance to spot things that we have missed. I missed the exit thing (I won't > next time!): others might have seen it and raised objections, and suggested > improvements before it all got into cvs. Using this approach many (useful) things will never get into CVS. What does 'No response' mean - no objections? nobody cares? nobody has actually tried and checked? I have no problem with broken CVS HEAD. After all its a revision management system, just checkout an older revision that works (i.e. the one before cvs up). Also check the updated version before starting to develop new things. That way you can easily distinguish between your own and CVS bugs (which you hopefully report). > Then we can all move ahead together. Surely that's not too much to ask? Thats way to slow for developers that have no CVS access. Some things you simply cannot do in a single patch. Having to review HUGE patches always is a pain. I was forced to install another version management on top of CVS (Arch - http://www.gnu.org/software/gnu-arch) to track my own development. It also seems to be not much of a problem as RECENT commit messages show: ==== /var/cvs/SimGear-0.3/source/simgear/environment/visual_enviro.cxx /var/cvs/SimGear-0.3/source/simgear/environment/visual_enviro.hxx revert last change (part ... === /var/cvs/FlightGear-0.9/source/src/Instrumentation/wxradar.cxx fix tacan (got broken by the last patch) ... === /var/cvs/FlightGear-0.9/source/src/Main/main.cxx sound: forgot the check for >zero === /var/cvs/FlightGear-0.9/source/src/Autopilot/xmlauto.cxx Fix a long standing bug in a code path that is probably executed very rarely in standard FG autopilots. === /var/cvs/FlightGear-0.9/source/src/Instrumentation/wxradar.cxx /var/cvs/FlightGear-0.9/source/src/Instrumentation/wxradar.hxx more cleanup, and fixing a lot of things that I've broken === (Intentionally no commiters, any bias due to checkin bias !!!) > Remember: P 6 - Piss Poor Peer-review Prevents Proper Performance There's also AFTDIP (Actually fixing things does improve performance) I'm really annoyed by the current trend to bash Durk. Stop it. Thomas -- PhD Student, Dept. Animal Physiology, HU Berlin Tel +49 30 2093 6173, Fax +49 30 2093 6375 ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Flightgear-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/flightgear-devel
