Hi, you have to know that FlightGear has never had a common coding style (at least not since I'm contributor, that is 2001/3). The rule was always that who starts writing a file decides for a style, and everyone adding to that file later respects this style. (There are exceptions, such as when a file became a real mess over the years, with five indentation styles in that single file etc., but that's a different story.)
There were discussions about unifying the style (excluding the imported, externally maintained parts, such as JSBSim/YASim/Nasal/ UIUC), but there never was a conclusion other than to keep things as they are. * till busch -- Sunday 20 January 2008: > what is the advantage of if-else-if-else-if? > more so: why "very often"? >From the generated machine code both are equivalent. There may be minor differences depending on the CPU instruction set, compiler, optimization settings, etc., but these are really pointless and not worth any consideration. Switch statements are sometimes nicer, when you have a limited set of symbols to consider, or want to use a "fallthrough", or have lots of branches with just a few instructions etc. But in the end it's a matter of taste. (Am I missing something?) And here we are back at what I wrote above: if the author of a file decided for or against a switch statement, then this was his decision. He designed the code, spent hours of work on it, and often still maintains it. It's highly unwelcome (and rude) to ignore the author's choice, especially if you haven't had anything meaningful to contribute to that code. Cosmetics patches are really not something that one should start with after entering a project. (And that's true for any project, not just FlightGear. And yes, I'm aware of your very welcome leak fixes. Thanks for that.) If you think your style is superior, then just contribute your own code, in your style. :-) Of course, if you take over some subsystem and overhaul it, almost rewrite it, then there's nothing wrong with changing the style (IMHO). > that's why i said i didn't want to step on anybody's feet. > seems like i already did. No, you didn't. You just announced that you were about to. ;-) m. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
