-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Curtis Olson wrote: | On Mon, Apr 28, 2008 at 4:26 PM, Benoît Laniel <[EMAIL PROTECTED] | <mailto:[EMAIL PROTECTED]>> wrote: | | First, let me thank you all for the great work you've done with FG. | | I started cross-compiling FG using the great fgfs-builder from Ralf and | I have to say that it helped a lot. However, I had to patch the source | code to make it possible. Here is the first one which basically replaces | SGMutex by OpenThreads::Mutex and allows to get rid of pthread. | | | Hi Benoit, | | I just want to jump in and point out that the threading code in | FlightGear and SimGear is very intricate and refined over much time, | blood, sweat, and tears. In addition, any little changes surrounding | the thread management or the contents of threaded code can easily | introduce very subtle bugs that aren't encountered very often and are | tremendously difficult to track down. Not knowing anything about | open-threads, I'm just a little nervous about any changes to | FlightGear's thread system. If OpenThreads has identical functionality
This concern is valid, but *every* use of SGMutex removed in Benôit's patch is not actually thread safe now! Static local variables are initialized the first time a function is called. I'm not sure if the proper lesson to take away is that threading is hard, because of subtle issues like this, or if it's easy, because it works even in the presence of such bugs ;) Tim -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iD8DBQFIGtIjeDhWHdXrDRURAtpqAKDehf+QDmCZVFJyyYqLXz7w91EzfgCgoyCC fR7HP6vT9Hj2A2ETgZe2+O4= =O1k6 -----END PGP SIGNATURE----- ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
