On 27 Nov 2008, at 11:50, Yon Uriarte wrote:

I changed it a bit, too. Now it passes the runways to the constructor and addRunways is private. But using swap sounds like the solution. It'll need 2 vectors in the apt.dat main loop, one with runways, the other one with taxis.

Right, I think that makes sense.

I sort of prefer to have a:
void FGAirport::addRunwaysAndTaxiways(std::vector<FGRunway*>& aRunways, std::vector<FGRunway*>& aTaxiways)

rather than constructor arguments, but that's a personal dislike of constructors with many arguments. Either way is acceptable!

 I agree with Melchior's comments about putting apt.dat specifics into
SimGear, the split helpers can happily live in apt_loader.cxx. That
way we'll know to delete them if I ever replace the file format.

Changed the name to split_inplace and patching airways parsing to use it. Still testing and timing. Possibly will look at the fix parsing, too, it's slowish.

Fair enough. Again, I may be changing how the data is loaded in the future, but short term gains are also good.

Thanks,
James

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to