Hi,
commenting inline. Im still programming a bit and measuring times. Patch
later.
On Wed, Nov 26, 2008 at 2:26 PM, Melchior FRANZ <[EMAIL PROTECTED]> wrote:
> Hi,
>
> * Yon Uriarte -- Wednesday 26 November 2008:
> > this is a patch to speed up startup times and some other
> > misc things.
>
> Thanks for taking care of that. Startup time is really a
> problem, made worse by the fact that one has to restart
> fgfs to use another aircraft.
>
> I'll leave commenting on the nasal, runway, and osg changes
> to the respective maintainers and focus on one thing:
>
> +++ misc/strutils.cxx 24 Nov 2008 17:13:29 -0000
> [...]
> /**
> + * Avoid new/delete/cpconstructor clusterfsck
> + */
> + int
> + split_whitespace_aptdat( const string& str, int maxsplit,
> vector<string>& res )
> [...]
> + split_aptdat( const string& str, const char* sep, int maxsplit,
> vector<string>& res )
>
>
> This is IMHO not acceptable!
>
> 1) If these functions are meant to be better than the
> existing split()/split_whitespace(), then they have to
> replace them. If they are different and customized for
> dealing with Robin PEEL's apt.dat file (as the name
> implies), then they have no place in SimGear. This
> is a set of generic libraries, and not (supposed to
> be) tied to FlightGear, let alone to Robin's DB.
I've renamed the functions and added meaningful comments.
>
>
> 2) The function head focuses on what the function
> doesn't do (avoids), rather than on what it does. If
> you think split()/split_whitespaces() are "fscking"
> something up, then please explain why you think they
> should keep doing that.
>
No, i dont think they should keep doing that. In the context of the file
it's written in (strutils.cxx) you can easily compare the 2 functions and
calculate in your head why the others are a cluster thing.
>
> 3) We value the coolness factor of f-words rather low,
> even when they are disguised as acronyms for "file
> system check". Hey, even the use of "WTF" is prohibited
> to my disappointment. (Whoops. :-)
>
WTF?? why? we are adults. Whatever, adult words removed.
>
>
> BTW: you introduced tabs in files that are space-indented,
> and even in a way that only works with 4-position tabs,
> rather than the standard: 8 positions.
Nothing i can do about that, let the CVS commiters pass a replace over the
files. MSVS is a hard master. Or is there an option to tell it not to mess
with my spaces?
>
>
> m.
>
greetings,
yon
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
