On 10 Mar 2010, at 07:27, adams....@gmail.com wrote: > Ive had a better look at the changes you made to my patch ... could you > please change them back ? > I'd prefer the option of setting these in the instrumentation.xml file , and > for safety sake , add the default settings back. > I appreciate your time on this , but consider the time i spent on it as > valuable... and i feel any modifications should be > discussed first and not done behind the scenes .
Okay, just to be clear: - I'll rename the 'has-barber-pole' to 'has-overspeed-indicator', as you suggested - and add back the default values of ias=250/ mach=0.48 / alt-threshold=13200 Things I think need to be discussed: - pressure-alt really needs to be a 'source' property; I'm fine with defaulting to /instruments/altimeter, but we shouldn't force it upon people, there's many other ways to compute an altitude reference. - making the limits and alt-threshold was mostly a style thing - reading the values of properties once, in the constructor, is not in the 'spirit' of the property system. Reading the values once, during 'init', is okay, but the pattern in most of the existing code is to read all property values dynamically (i.e, during update()), which is what I changed the code to do. Maybe my comment about 'changed from Nasal' was misleading, I'm not really suggesting these properties particularly need to be dynamically configured, but for example it does mean the values can be tweaked in the Property Inspector during aircraft development. With your original code, changes made that way will not be picked up. Obviously 99% of the time the values would come from instrumentation.xml as you intended. Regards, James ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
