On Sun, 11 Jul 2010, Hal V. Engel wrote:
> This is a large merge that is a significant enhancement to the existing P-51D
> but it is still a work in progress and much remains to be done. At the moment
> I am not able to spend much time working on this but it is far enough along
> that I think it belongs in the FG mainline so that it can be tested against
> 2.1 and hopefully released with 2.1. I intend to keep working on this as time
> permits and my intention is to eventually make this the most complete and most
> accurate model in the FlightGear hanger.
Hi Hal,
Lovely aircraft!
One thing I discovered after a few botched landings is that the crash
detection system doesn't set /sim/crashed. I think it ought to since that
is the standard crash indicator in FlightGear. It is easy to add as the
following diff shows:
index 312f0ce..bd2e03f 100644
--- a/Aircraft/p51d/Systems/crash-detect.xml
+++ b/Aircraft/p51d/Systems/crash-detect.xml
@@ -56,6 +56,7 @@
<output>/sim/freeze/clock</output>
<output>/sim/freeze/main</output>
<output>/controls/engines/engine[0]/cutoff</output>
+ <output>/sim/crashed</output>
</switch>
</channel>
It is also easy to update the merge request - I have tried it on some of
mine.
PS.
For those who want to try the p51d before the merge request is accepted
and aren't that familiar with git here are the steps to get Hal's branch:
git fetch git://gitorious.org/~hvengel/fg/hvengels-fgdata-p51d-jsbsim.git
master:hvengel/p51d-jsbsim
git merge hvengel/p51d-jsbsim
If you have push access to fgdata it might be advisable to create a
separate branch for this so that you don't accidentally push these
changes. (As far as I have checked they don't interfere with anything -
but if we want to keep the gitorious merge request function functional it
might be better if whoever merges this contribution use that procedure
instead).
Btw. local finger trouble with git can easily be adjusted using git
rebase, see this very useful site for more information:
http://www-cs-students.stanford.edu/~blynn/gitmagic/ch05.html
Take care NOT to change published commits, though.
DS.
Cheers,
Anders
--
---------------------------------------------------------------------------
Anders Gidenstam
WWW: http://www.gidenstam.org/FlightGear/
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
