Hi Melchior,

I was about to send an email to the mailing list asking for feedback, so thanks 
for saving 
my three minutes :)

> Shudder! This patch simply duplicates a lot of code that was meant
> to be *re-used*. 

Right. So far it was a proof of concept. What it needs now is someone to clean 
the code
up and improve it. I agree that it might have been better to distribute it 
through a diff, 
rather than commiting it yet, though; but given the fact that it only adds 
something (and 
doesn't break anything else; atleast it should not) it is not a very big deal I 
think to have 
it temporarily like this in Git... (don't get me wrong, I won't say it was 
right to do!)
 
Anyway, next time I'll do it differently for sure; I learn something new every 
day. Sorry
for now.
 
> A whole Nasal class for screenshot dir selectors, in addition to already 
> existing generic 
> file selectors?

As far as I was able to find out the screen-capture command does not (yet) 
support 
filenames. Only directories. So we needed a directory selector, rather than 
file selector...
Nicer solutions are welcome as always.
 
Cheers and once again sorry!
Gijs                                      
------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to