Hi all.

I just noticed an old "bug" still existing in (my!) old code. I
currently have no possibility to git pull the latest code and do a
merge request, so maybe someone could do this little change to the
code:

In simgear/scene/material/EffectGeode.cxx, around line 73. All tangent
generators currently run for every model using <generate> tag, even if
the value is not stored. So maybe modifying the code to look like this
would fix it:

if(geometry && _effect.valid()) {
 if(_effect->getGenerator(Effect::TANGENT)>=0 ||
_effect->getGenerator(Effect::BINORMAL>=0 ||
_effect->getGenerator(Effect::NORMAL)>=0) {
// Generate tangent vectors for the geometry
...
...
  }
 }
}

<end of function>

Currently there might be no significant change, as only generators
available are for tangent vectors AFAIK, but this might come in handy
later if more generators are added.

Cheers, Lauri
--
Lauri Peltonen
lauri.pelto...@gmail.com

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to