On 13 Oct 2013, at 12:04, Flightgear-commitlogs <mar...@hypersphere.calit2.net> 

> +            catch(...)
> +            {
> +              naRuntimeError(c, "Unknown exception in method call.");
> +            }
> +

I am slightly concerned about catching all exceptions this way - I agree 
catching std::exception is worthwhile, with the specialisation for sg_exception 
since we can provide better logging and reporting, but I really hope no-one is 
throwing arbitrary objects not inheriting from std::exception. We used to have 
some bad cases of people throwing std::string but I cleaned those up years ago.

I guess it's not that this does any harm (except for more exception handling 
overhead, which is probably very low), I just dislike the idea such a thing is 
ever needed for us - it's not like we are calling into arbitrary plugin code 
which might throw anything.

Kind regards,

October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
Flightgear-devel mailing list

Reply via email to