DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

Link: http://www.fltk.org/str.php?L2479
Version: 1.3-current
Fix Version: 1.3-current (r8067)


Great work, Greg !
Your research of behavior in other tools and apps. is awesome !
Thanks a lot !!!

I have 3 comments:

(1) The documentation mixes "selection (buffer)" and "clipboard" in some
places. The code seems to be okay, however. We must make clear that
selecting text moves it to the selection buffer (same as copy(0)) and
using CTRL/C puts the selected text into the clipboard (aka cut/paste
buffer, same as copy(1)). Unfortunately this is not clear at other places
as well, but I noticed that Manolo tried to improve it somewhere else
recently (I don't recall where exactly). The reverse is clicking with
mouse button 2 (selection buffer) and CTRL/V (clipboard or cut/paste
buffer).

Tested and works well: select '1st text', press CTRL/C, select '2nd text',
press MB2: this inserts '2nd text', press CTRL/V: this inserts '1st text'.
Fine :-)

(2) The returned value when ignoring key presses seems to be inconsistent
in some places, notably (but not exclusive):

    case FL_Delete: {
      ...
      return 0;  // ignore other combos, pass to parent

    case FL_Left:
      ...
      return 1;  // other combos absorb and ignore

(Code shortened to fit on one line). Is this intentional? Do we need to
care whether the key combo can be a valid shortcut for other widgets (then
we should presumably pass it and return 0), or not (then we should consume
it and return 1). I don't know what's right here.

(3) Fl_Input::kf_delete_eol() checks readonly(), whereas
Fl_Input::kf_delete_sol() does not (it should).

Thanks for the great work.


Link: http://www.fltk.org/str.php?L2479
Version: 1.3-current
Fix Version: 1.3-current (r8067)

_______________________________________________
fltk-bugs mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-bugs

Reply via email to