imacarthur wrote: > > On 10 Nov 2008, at 18:16, Albrecht Schlosser wrote: >> >> HAVE_LIBPNG_PNG_H isn't used explicitly, but implicitly in >> Fl_PNG_Image.cxx as >> the alternate header location. It doesn't really matter if we test it, >> but I have >> added both tests, and it works as I expect. >> >> Fabien, so far your modifications look pretty good :-) >> >> I'll commit my addition shortly, please have a look at this one. I >> think that it >> solves Ian's problem. I can confirm it, if I configure with: >> >> ./configure --enable-cygwin --enable-threads >> >> Please review my update. > > Just tested on my Mac, and the latest configure now (on OSX) sets both > PNG_H options in config.h; > > #define HAVE_PNG_H 1 > #define HAVE_LIBPNG_PNG_H 1 > > But that's sort of OK, since the first one takes precedence here, I > guess. Still seems wrong though...
I did this intentionally, because with this approach we could check the existence of both header files in Fl_PNG_Image.cxx, and if neither exists, do something useful (disable PNG code or issue a #error and terminate compilation). We can also omit checking the 2nd header, if we found the first. Albrecht _______________________________________________ fltk-dev mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-dev
