>> I noticed this comment in Fl_Browser_.cxx: >> >> // Scrollbar size should be part of the Fl class, but is left here for >> // binary compatibility in 1.1.x - M. Sweet >> int Fl_Browser_::scrollbar_width_ = 16; >> >> I'm thinking 'now's the time to do it' here in the 1.3.x release >> if it's an ABI issue..
> Made STR #2176 instead: > http://fltk.org/str.php?L2176 Hmm, OK, I think I see what's going on here. The methods for Fl::scrollbar_size() *already exist* in Fl.H. (Didn't realize that) The /implementation/ for these methods are not in Fl.cxx though.. they're (oddly) in Fl_Browser_.cxx, probably to avoid some kind of ABI issue, or something. And these Fl::scrollbar_size() methods refer to a static int that resides in Fl_Browser.cxx, instead of Fl.cxx So I /think/ all that's needed here is to: 1) Move the definition of the integer over to Fl.cxx (ABI issue) 2) Relocate the implementations of Fl::scrollbar_size() over to Fl.cxx where they belong. (Not an ABI issue) 3) Change the Fl_Browser_ code around to refer to Fl::scrollbar_size() instead of the static integer that was defined in Fl_Browser_.cxx (which probably is not an ABI issue either) It looks like the other widgets (Fl_Scroll, Fl_Help_View, etc) already refer to Fl::scrollbar_size() -- it's only (oddly) Fl_Browser that doesn't. So I think that footwork has already been done. If that sounds right, it sounds easy enough for me to do. In which case I'll update the STR with the above, assign it to myself after I check in the docs modifications I'm making which I'll hopefully wrap up today. _______________________________________________ fltk-dev mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-dev
