Greg Ercolano wrote: > OK, I've made STR #2301 for this to ensure it doesn't fall through the cracks.
Good idea, thanks. > Regarding the POLL* errors, I'll leave that to you all to apply, as I'm pretty > sure I'm not seeing all the ins and outs of those macro's use. Well, after looking at Fl_x.cxx, I'm not sure that anybody can see all the ins and outs... ;-P This is a mix of using select() and poll() (#if USE_POLL), and in one case (USE_POLL) the POLL* macros are defined in the header file, and in the other case (!USE_POLL) select() is used, and the POLL* macros are defined in the source file. This doesn't make it very clear after all. I'd like to look at this tomorrow again. > Regarding the FORCE_POSITION error, it sounds like there's agreement > changing "Fl_Widget::FORCE_POSITION" -> "Fl_Window::FORCE_POSITION" > will solve it, and if so, I'll apply that fix and check it in > after first verifying it doesn't break compiles for the VS 7.0 .NET compiler. This wouldn't hurt, but meanwhile I came to the conclusion that adding two new methods and using them would be much cleaner, make the code shorter, and avoid this compiler specific hassle: void Fl_Window::force_position(int); int Fl_Window::force_position(); These will be short inline methods in Fl_Window.H and deprecate the existing method Fl_Window::free_position() which can be replaced by Fl_Window::force_position(0). I'll check that tomorrow, and if I don't find any reasons against it, I'll check it in. ... time goes by ... Okay, now I posted a preliminary patch file to the STR: http://www.fltk.org/strfiles/2301/Fl_win32.diff Needs regression testing, but I think that it's okay. Comments welcome. Please test if this compiles w/o errors. Albrecht _______________________________________________ fltk-dev mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-dev
