On 21 Dec 2009, at 8:31, Albrecht Schlosser wrote: > The events argument is tested for POLLIN etc., but is defined to > use the FL_READ etc. constants in the interface documentation. > > <http://www.fltk.org/doc-1.3/ > classFl.html#76b6c3f9043d22034a47177914fd4054> > > Now, looking at this again, I remember that I once wondered why the > code doesn't use the FL_* constants instead of declaring its own, > but maybe this is for some "code compatibility" with other platforms, > where the POLL* constants are defined. > > Conclusion: > > IMO the _correct_ solution is to replace POLL* with FL_* (see above) > and *not* to define them in Fl_win32.cxx at all. The second best > solution would be to undefine and redefine them, but I think that > this would only lead to confusion. > > We'll also have to check this (matching POLL* an FL_*) for other > platforms as well...
Do the other platforms actually define these values, though? It looks (on a very cursory check by me, so NOT definitive) that we always define these values? In any case, I think we could, as Albrecht suggests, define our own FL_POLLIN etc to avoid the problem, and have it set to match FL_READ, or the local POLLIN (if it exists) or whatever. Matching the "new" MS POLLIN value doesn't look right to me - it seems to serve a different function and contains two bits, one for in- band and one for out-of-band data... -- Ian _______________________________________________ fltk-dev mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-dev
