> > > I have no idea why my patch changed the behavior of take_focus()
> > > in such a way, but I'll investigate this later - I'm really
> > > curious. If anybody could tell me, I'd appreciate it...
> >
> > For the record: it turned out that something else changed the
> > take_focus() behavior. This seems like a regression in fltk 1.3
> > and should be investigated.
>
> I found the regression: it's in svn r7788, file FL/Fl_Widget.H:
>
> Index: FL/Fl_Widget.H
> ===================================================================
> --- FL/Fl_Widget.H (revision 7787)
> +++ FL/Fl_Widget.H (revision 7788)
> @@ -752,7 +752,9 @@
> && visible()) but is faster.
> \retval 0 if the widget takes no events
> */
> - unsigned int takesevents() const {return
> !(flags_&(INACTIVE|INVISIBLE|OUTPUT));}
> + unsigned int takesevents() const {
> + return !output() && active_r() && visible_r();
> + }
Well, I don't know what is going on there, but reading the comment in
the source, it looks as if that would be expected to be OK, but clearly
the behaviour has changed...
The comment is perhaps now wrong - it says the takesevents() method is
"faster" than explicitly doing the things that it now actually does... I
guess the old method (that simply tested the flags) may well have been
faster though!
It seems Matt has looked at this recently, and I think Manolo was too,
so they maybe have a better grasp of what is going on (I hope! I know
I'm lost here...)
SELEX Galileo Ltd
Registered Office: Sigma House, Christopher Martin Road, Basildon, Essex SS14
3EL
A company registered in England & Wales. Company no. 02426132
********************************************************************
This email and any attachments are confidential to the intended
recipient and may also be privileged. If you are not the intended
recipient please delete it from your system and notify the sender.
You should not copy it or use it for any purpose nor disclose or
distribute its contents to any other person.
********************************************************************
_______________________________________________
fltk-dev mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-dev
