On 03.08.2011 10:17, [email protected] wrote:
> Author: ianmacarthur
> Date: 2011-08-03 01:17:34 -0700 (Wed, 03 Aug 2011)
> New Revision: 8911
> Log:
> fix typo in debug output, as per #2690
>
>
>
> Modified:
>     branches/branch-1.3/src/Fl_Text_Display.cxx
>
> Modified: branches/branch-1.3/src/Fl_Text_Display.cxx
> ===================================================================
> --- branches/branch-1.3/src/Fl_Text_Display.cxx       2011-08-02 21:53:45 UTC 
> (rev 8910)
> +++ branches/branch-1.3/src/Fl_Text_Display.cxx       2011-08-03 08:17:34 UTC 
> (rev 8911)
> @@ -74,16 +74,16 @@


This is just to clarify things, no offense intended...

Ian, I saw you commit in svn r 8911, which is effectively a one-liner,
but obviously something in your editor setup (or a habit of yours) is
removing trailing white space from source files, and this is not the
only (first) commit affected by this.

Although I would *like* to *not* have trailing white space, it seems
that some other devs (or their editors) add trailing white space,
particularly to empty lines that follow other indented lines.
(See the diffs in r 8911).

So, what happens now, is that the commit logs (and the subversion
repository) gets lots of unnecessary changes, and it is confusing
(or should I say annoying?) to see these huge commit messages.

Additionally this will make the dev who changed these lines the
one to (svn) "blame" for these changes, and that's maybe not what
we want.

Now that Matt is working on FLTK 3 (well, what's the plan now, will
we switch over...?), we could probably take the opportunity to clean
all sources from trailing white space and try to keep it this way,
maybe. Or, we could remove all automatic stripping of white space
from our editors.

Opinions, anybody?

BTW, just for curiosity: Ian, can you tell us why your editor seems
to do this? Is it a setup you use for your own projects? Which editor?

Albrecht
_______________________________________________
fltk-dev mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-dev

Reply via email to