DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR Pending]

Link: http://www.fltk.org/str.php?L2948
Version: 1.3-feature
Fix Version: 1.3-current (r9871)


Thanks Greg for implementing exactly what I was getting at.

I still have a few remarks about the current implementation of:
Fl_Window* Fl_Widget::top_window_offset(int&, int&)

- The doc should say 'current widget' instead of 'current window'
because a widget is now current.

- I feel the widget-to-window cast
const Fl_Window *win = (const Fl_Window *)this;
is frightening, because widgets are not windows, in general.
It works here because only member functions from the parent Fl_Widget
class are employed. Rewriting it
Fl_Widget *win = (Fl_Widget*)this;
does just the same, removing the fear.

- This implementation applied to a window-less widget returns
this widget cast as a window, a potentially dangerous thing. 
My suggestion would be to use (again) our friend Fl_Widget::as_window().

The attached window.patch gathers all of this.


Link: http://www.fltk.org/str.php?L2948
Version: 1.3-feature
Fix Version: 1.3-current (r9871)

_______________________________________________
fltk-dev mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-dev

Reply via email to