DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR Pending]

Link: http://www.fltk.org/str.php?L2948
Version: 1.3-feature
Fix Version: 1.3-current (r9871)


@manolo: Great -- agree with all, except perhaps loosing const here:

-  const Fl_Window *win = (const Fl_Window*)this;
+  Fl_Widget *win = (Fl_Widget*)this;

I think we can maintain const protection on the variable this way:

    const Fl_Widget *win = this;
    :
    return ((Fl_Widget*)win)->as_window();

..this ensures const protection for all uses of win within the code,
and we only turn it off when we need to (eg. the non-const as_window()
call)

Also, I should probably change all instances of 'win' -> 'w' in the
code, since it's really working with widgets now.

Thanks for the peer review -- will hold on comments regarding const
above, as am curious if there's a reason not to.


Link: http://www.fltk.org/str.php?L2948
Version: 1.3-feature
Fix Version: 1.3-current (r9871)

_______________________________________________
fltk-dev mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-dev

Reply via email to