Marc R.J. Brevoort wrote:
> Hello Domingo,
>
>> If do you want to try a slight modified version of Fl_Help_view have a
>> look at http://code.google.com/p/luafltk/.
>> I did some modifications that aren't well accepted to be in the official
>> distribution but it helped me get a better result for my purposes.
>
> What kind of modifications if I may ask?
>
> Best,
> Marc
>
There was a thread back in March 2010 on fltk.development about this;
do a search on the webforum for (including quotes):
"Fl_Help_View code cleanup"
Thread started with:
http://fltk.org/newsgroups.php?gfltk.development+v:9351
..which has a description of the changes. Possibly other
changes were added as that thread continued.. it was a long
thread, don't remember details.
Probably very reasonable code fixups, but unfortunately it included
code /reformatting/ that made diffing and regression checking difficult,
and apparently made the code less compatible with the FLTK coding standards
due to the formatting changes, causing these responses:
http://fltk.org/newsgroups.php?gfltk.development+v:9354
http://fltk.org/newsgroups.php?gfltk.development+v:9355
I don't think the mods were rejected on technical merit,
just that the code reformatting made it un-diff'able..
and since Fl_Help_View's code is a bit of a bear, we need
to track it carefully.
Thread got into a few side tracking issues (using code re-indenter's,
issues of static strings, etc), but I think if Domingo went back to the
original source, and made the code changes without reformatting/indenting the
code, and kept the new code in CMP format, and the old code untouched so that
it can all be diff'ed easily, it probably would have been excepted.
I know I myself have had to do such seemingly redundant things in the past
on this and other projects to ensure diff's were minimal.. it's part of the
process of joining on with a code base managed by multiple people; it's
important
to keep diffs as small as possible.
_______________________________________________
fltk mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk
