Thanks for the quick response, Charly. I see you point. I will give a try on sub-components.
Cindy On 2012-01-03, at 1:52 PM, charly molter wrote: Hello, I think I used the decorator in order to have a more modular thing easy to remove bits. I thought that was easier. Maybe I got it wrong. If you see another way of doing it it might be right too. It was written in subcomponents in the beginning I think. But I was having issue with the templating. I couldn't just remove something from the html and not instanciate the depending components. I don't know if I'm clear enough about that. Best regards Charly On Tue, Jan 3, 2012 at 7:07 PM, Li, Cindy <[email protected]<mailto:[email protected]>> wrote: In case any of you is interested in this topic. Begin forwarded message: From: Cindy Qi Li <[email protected]<mailto:[email protected]>> Subject: The use of "decorator" in the video player Date: 3 January, 2012 11:59:09 AM EST To: charly molter <[email protected]<mailto:[email protected]>> Cc: Michelle D'Souza <[email protected]<mailto:[email protected]>>, Anastasia Cheetham <[email protected]<mailto:[email protected]>> Hi Charly, Hope you had a great holiday. As you know that we are working on a bunch of jiras to polish up your video player code (http://wiki.fluidproject.org/display/fluid/Floe+Iteration+Plan). The issue 4545 (http://issues.fluidproject.org/browse/FLUID-4545) is that in your video player scripts, there're a few places using decorators rather than sub-components. For instance, https://github.com/fluid-project/videoPlayer/blob/master/js/VideoPlayer.js#L206-246 https://github.com/fluid-project/videoPlayer/blob/master/js/VideoPlayer_controllers.js#L187-210 We wonder if there were reasons or difficulties that stopped you from using sub-components and had to go with decorators? Cindy _______________________________________________________ fluid-work mailing list - [email protected]<mailto:[email protected]> To unsubscribe, change settings or access archives, see http://lists.idrc.ocad.ca/mailman/listinfo/fluid-work -- Charly Molter
_______________________________________________________ fluid-work mailing list - [email protected] To unsubscribe, change settings or access archives, see http://lists.idrc.ocad.ca/mailman/listinfo/fluid-work
