[ 
https://issues.apache.org/jira/browse/FLUME-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081283#comment-13081283
 ] 

Mingjie Lai commented on FLUME-722:
-----------------------------------

@jon Thanks for your comments. 

I created https://review.cloudera.org/r/1891/ for easier review. And I also 
posted a new patch which includes the test case at the rb. 

> RegexAllExtractor doesn't ignore empty groups
> ---------------------------------------------
>
>                 Key: FLUME-722
>                 URL: https://issues.apache.org/jira/browse/FLUME-722
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v0.9.4
>            Reporter: Nicholas Verbeck
>            Assignee: Mingjie Lai
>            Priority: Minor
>              Labels: decorator, regexall
>             Fix For: v0.9.5
>
>         Attachments: FLUME-722.patch
>
>
> Hi flume devs.
> I saw a bug when using RegexAllExtractor: line 94:
>          if(names.get(grp-1) != ""){
>            Attributes.setString(e, names.get(grp-1), val);
>          }
> Please help to file a jira and correct it to use String.equal(), otherwise it 
> doesn't ignore empty groups.
> (I don't think I can open a issue at cloudera jira.)
> Thanks,
> Mingjie

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to