[
https://issues.apache.org/jira/browse/FLUME-722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082202#comment-13082202
]
[email protected] commented on FLUME-722:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1448/
-----------------------------------------------------------
(Updated 2011-08-10 07:11:31.240611)
Review request for Flume and jmhsieh.
Changes
-------
Update do include link to jira issue
Summary
-------
Reposted for Mingjie Lai (was originally posted and reviewed on
https://review.cloudera.org/r/1891/)
This addresses bug flume-722.
https://issues.apache.org/jira/browse/flume-722
Diffs
-----
/trunk/flume-core/src/main/java/com/cloudera/flume/core/extractors/RegexAllExtractor.java
1155987
/trunk/flume-core/src/test/java/com/cloudera/flume/core/extractors/TestExtractors.java
1155987
Diff: https://reviews.apache.org/r/1448/diff
Testing
-------
Ran test, it passed.
Thanks,
jmhsieh
> RegexAllExtractor doesn't ignore empty groups
> ---------------------------------------------
>
> Key: FLUME-722
> URL: https://issues.apache.org/jira/browse/FLUME-722
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v0.9.4
> Reporter: Nicholas Verbeck
> Assignee: Mingjie Lai
> Priority: Minor
> Labels: decorator, regexall
> Fix For: v0.9.5
>
> Attachments: FLUME-722.patch
>
>
> Hi flume devs.
> I saw a bug when using RegexAllExtractor: line 94:
> if(names.get(grp-1) != ""){
> Attributes.setString(e, names.get(grp-1), val);
> }
> Please help to file a jira and correct it to use String.equal(), otherwise it
> doesn't ignore empty groups.
> (I don't think I can open a issue at cloudera jira.)
> Thanks,
> Mingjie
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira