[ 
https://issues.apache.org/jira/browse/FLUME-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158038#comment-13158038
 ] 

[email protected] commented on FLUME-823:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2945/
-----------------------------------------------------------

Review request for Flume and Eric Sammer.


Summary
-------

Based on the discussion in FLUME-823, this patch implements the fail-fast 
scenario for missing configuration file when invoked from the command line. In 
order to circumvent this check the system property "flume.called.from.service" 
should be set to a non-null value.


This addresses bug FLUME-823.
    https://issues.apache.org/jira/browse/FLUME-823


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/Constants.java PRE-CREATION 
  flume-ng-node/src/main/java/org/apache/flume/node/Application.java eabeec1 

Diff: https://reviews.apache.org/r/2945/diff


Testing
-------

Manually verified that if the file specified does not exist the process exits. 
If the file is specified but does not contain valid configuration for the node 
being configured, a warning is printed on the console.


Thanks,

Arvind


                
> The properties configuration provider should fail if the configuration file 
> is not found
> ----------------------------------------------------------------------------------------
>
>                 Key: FLUME-823
>                 URL: https://issues.apache.org/jira/browse/FLUME-823
>             Project: Flume
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: NG alpha 1
>            Reporter: Will McQueen
>            Assignee: Arvind Prabhakar
>             Fix For: NG alpha 2
>
>         Attachments: FLUME-823-1.patch
>
>
> When specifying a props file (eg, flume.properties) that doesn't exist, the 
> logs don't indicate any failure to read the config file. The configuration 
> provider should probably just fail if the config file isn't found.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to