----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3516/#review5045 -----------------------------------------------------------
Ship it! +1. Changes look good to me. Please attach the patch to the JIRA. - Arvind On 2012-02-06 23:09:15, Peter Newcomb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3516/ > ----------------------------------------------------------- > > (Updated 2012-02-06 23:09:15) > > > Review request for Flume. > > > Summary > ------- > > Implementation of FLUME-935 as new classes BasicChannelSemantics, > BasicTransactionSemantics, and ChannelUtils. It might be better to fold > BasicChannelSemantics into AbstractChannel and rename > BasicTransactionSemantics to AbstractTransaction, but doing that would > require refactoring of existing classes that extend AbstractChannel. > > > This addresses bug FLUME-935. > https://issues.apache.org/jira/browse/FLUME-935 > > > Diffs > ----- > > > /branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/channel/AbstractBasicChannelSemanticsTest.java > PRE-CREATION > > /branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/channel/ChannelUtils.java > PRE-CREATION > > /branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/ChannelException.java > 1241246 > > /branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/channel/BasicChannelSemantics.java > PRE-CREATION > > /branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/channel/BasicTransactionSemantics.java > PRE-CREATION > > /branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/channel/TestBasicChannelSemantics.java > PRE-CREATION > > /branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/channel/TestChannelUtils.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3516/diff > > > Testing > ------- > > I am using these in production code, and they have survived significant > integration testing there, including failure modes. Note also that these > classes are largely error handling and precondition testing code designed to > test the correctness of the code around them. > > A fairly comprehensive set of unit tests is included. > > > Thanks, > > Peter > >
