----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3924/#review5164 -----------------------------------------------------------
branches/flume-728/flume-ng-log4jappender/src/main/java/org/apache/flume/log4jappender/Log4jAppender.java <https://reviews.apache.org/r/3924/#comment11312> Excellent error messages! The only comment I have is, should we pass the exception along so that people can see the stacktrace: throw new FlumeException(errormsg, e); - Brock On 2012-02-16 17:47:02, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3924/ > ----------------------------------------------------------- > > (Updated 2012-02-16 17:47:02) > > > Review request for Flume. > > > Summary > ------- > > A class which takes in a LoggingEvent and sends it to a predefined AvroSource > at a given host and port. > > > This addresses bug FLUME-886. > https://issues.apache.org/jira/browse/FLUME-886 > > > Diffs > ----- > > branches/flume-728/flume-ng-log4jappender/pom.xml PRE-CREATION > > branches/flume-728/flume-ng-log4jappender/src/main/java/org/apache/flume/log4jappender/Log4jAppender.java > PRE-CREATION > > branches/flume-728/flume-ng-log4jappender/src/main/java/org/apache/flume/log4jappender/Log4jAvroHeaders.java > PRE-CREATION > > branches/flume-728/flume-ng-log4jappender/src/test/java/org/apache/flume/log4jappender/TestLog4jAppender.java > PRE-CREATION > > branches/flume-728/flume-ng-log4jappender/src/test/resources/log4j.properties > PRE-CREATION > branches/flume-728/pom.xml 1244858 > > Diff: https://reviews.apache.org/r/3924/diff > > > Testing > ------- > > Added unit tests. > > > Thanks, > > Hari > >
