----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3924/#review5226 -----------------------------------------------------------
Thanks for incorporating the feedback Hari. Change looks good, a couple of minor suggestions follow. branches/flume-728/flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java <https://reviews.apache.org/r/3924/#comment11424> A brief javadoc will be good that describes this implementation. branches/flume-728/flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java <https://reviews.apache.org/r/3924/#comment11423> Not sure if this is a valid assumption since the first line of the append() method raises an exception if the protocol client is null. Also, if we must dispose the protocol client, the underlying transceiver should be closed as well in order to ensure there are no resource leaks. - Arvind On 2012-02-20 22:54:11, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3924/ > ----------------------------------------------------------- > > (Updated 2012-02-20 22:54:11) > > > Review request for Flume. > > > Summary > ------- > > A class which takes in a LoggingEvent and sends it to a predefined AvroSource > at a given host and port. > > > This addresses bug FLUME-886. > https://issues.apache.org/jira/browse/FLUME-886 > > > Diffs > ----- > > branches/flume-728/flume-ng-clients/flume-ng-log4jappender/pom.xml > PRE-CREATION > > branches/flume-728/flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java > PRE-CREATION > > branches/flume-728/flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAvroHeaders.java > PRE-CREATION > > branches/flume-728/flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java > PRE-CREATION > > branches/flume-728/flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-log4jtest.properties > PRE-CREATION > branches/flume-728/flume-ng-clients/pom.xml PRE-CREATION > branches/flume-728/pom.xml 1244858 > > Diff: https://reviews.apache.org/r/3924/diff > > > Testing > ------- > > Added unit tests. > > > Thanks, > > Hari > >
