[ 
https://issues.apache.org/jira/browse/FLUME-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220765#comment-13220765
 ] 

[email protected] commented on FLUME-1001:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4152/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

Made custom processors possible in the same way as sink and source: the type 
can represent a classname or a shorthand name from the typedef.


This addresses bug FLUME-1001.
    https://issues.apache.org/jira/browse/FLUME-1001


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b 
  flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 
10f9f4e 
  
flume-ng-core/src/test/java/org/apache/flume/sink/TestSinkProcessorFactory.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/4152/diff


Testing
-------

Existing tests pass, except I'm having an issue with TestNetcatSource which 
seems to be totally unrelated... It turns up on flume-728 head too, probably 
something in my environment

Added a new test to verify that processors created by shorthand name and by 
full class create the same class, verifying that creation by classname also 
works


Thanks,

Juhani


                
> Support custom processors
> -------------------------
>
>                 Key: FLUME-1001
>                 URL: https://issues.apache.org/jira/browse/FLUME-1001
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>         Environment: RHEL 6.2 64-bit
>            Reporter: Will McQueen
>            Assignee: Juhani Connolly
>             Fix For: v1.1.0
>
>
> Currently there doesn't seem to be a way for a user to specify a custom 
> processor... for example, a replicating processor that replicates a channel's 
> output to all sinks. If this is implemented in a way to how custom sources 
> and sinks are implemented, then we'd need a SinkProcessor.OTHER type, as a 
> start.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to