[
https://issues.apache.org/jira/browse/FLUME-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222146#comment-13222146
]
[email protected] commented on FLUME-1001:
------------------------------------------------------
bq. On 2012-03-02 16:47:32, Will McQueen wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java,
line 40
bq. > <https://reviews.apache.org/r/4152/diff/2/?file=87333#file87333line40>
bq. >
bq. > For consistency with the other types (SinkType, SourceType, ...),
can we please put OTHER at the top of the enum listing?
bq. >
bq. > Also for same consistency, can we have the comment read:
bq. >
bq. > /**
bq. > * Place holder for custom sink processors not part of this
enumeration.
bq. > */
Makes sense, done
bq. On 2012-03-02 16:47:32, Will McQueen wrote:
bq. >
flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java,
line 40
bq. > <https://reviews.apache.org/r/4152/diff/2/?file=87334#file87334line40>
bq. >
bq. > Before this line:
bq. > Preconditions.checkNotNull(context);
bq. > Preconditions.checkNotNull(sinks);
bq. > logger.debug("Creating instance of sink processor name {}, type {}",
name, type);
Added precondition checks, changed the debug message a bit because processors
belong to a sink group and thus themselves are not named.
bq. On 2012-03-02 16:47:32, Will McQueen wrote:
bq. >
flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java,
line 48
bq. > <https://reviews.apache.org/r/4152/diff/2/?file=87334#file87334line48>
bq. >
bq. > => "Sink processor type {} is a custom type"
bq. >
bq. > (this string output matches the convention used by
DefaultSourceFactory)
ok
bq. On 2012-03-02 16:47:32, Will McQueen wrote:
bq. >
flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java,
line 66
bq. > <https://reviews.apache.org/r/4152/diff/2/?file=87334#file87334line66>
bq. >
bq. > add "sink", remove comma:
bq. >
bq. > =>"Unable to create sink processor type: "
bq. >
done
- Juhani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4152/#review5557
-----------------------------------------------------------
On 2012-03-02 07:51:49, Juhani Connolly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4152/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-02 07:51:49)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Made custom processors possible in the same way as sink and source: the
type can represent a classname or a shorthand name from the typedef.
bq.
bq.
bq. This addresses bug FLUME-1001.
bq. https://issues.apache.org/jira/browse/FLUME-1001
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java
be1891b
bq.
flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java
10f9f4e
bq.
flume-ng-core/src/test/java/org/apache/flume/sink/TestSinkProcessorFactory.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4152/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Existing tests pass, except I'm having an issue with TestNetcatSource
which seems to be totally unrelated... It turns up on flume-728 head too,
probably something in my environment
bq.
bq. Added a new test to verify that processors created by shorthand name and
by full class create the same class, verifying that creation by classname also
works
bq.
bq.
bq. Thanks,
bq.
bq. Juhani
bq.
bq.
> Support custom processors
> -------------------------
>
> Key: FLUME-1001
> URL: https://issues.apache.org/jira/browse/FLUME-1001
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.1.0
> Environment: RHEL 6.2 64-bit
> Reporter: Will McQueen
> Assignee: Juhani Connolly
> Fix For: v1.1.0
>
>
> Currently there doesn't seem to be a way for a user to specify a custom
> processor... for example, a replicating processor that replicates a channel's
> output to all sinks. If this is implemented in a way to how custom sources
> and sinks are implemented, then we'd need a SinkProcessor.OTHER type, as a
> start.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
