> On 2012-03-05 03:20:15, Juhani Connolly wrote: > > This seems fine... However without the change being propagated to the sinks > > to make them throw appropriate errors it will be misleading. Do you think > > you could update the sinks/processors to account for the new exception? If > > not, we can just push this and I'll open a separate ticket to do that...
You mean update the sink signature so that they know they can throw FatalException? - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3980/#review5608 ----------------------------------------------------------- On 2012-02-29 10:42:17, Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3980/ > ----------------------------------------------------------- > > (Updated 2012-02-29 10:42:17) > > > Review request for Flume. > > > Summary > ------- > > Catches, logs, and sleeps when a general exception occurs. This is similar to > PollingSourceRunner. > > > This addresses bug FLUME-984. > https://issues.apache.org/jira/browse/FLUME-984 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/FatalException.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java > 264fce1 > flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java 9e46d87 > > Diff: https://reviews.apache.org/r/3980/diff > > > Testing > ------- > > All unit tests pass. > > > Thanks, > > Brock > >
