----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3980/#review5845 -----------------------------------------------------------
Ship it! +1. Some minor comments below. Please address those if possible and attach the updated patch to the Jira. flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java <https://reviews.apache.org/r/3980/#comment12738> Longer than 80 char. flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java <https://reviews.apache.org/r/3980/#comment12739> Longer than 80 char. - Arvind On 2012-03-12 18:52:15, Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3980/ > ----------------------------------------------------------- > > (Updated 2012-03-12 18:52:15) > > > Review request for Flume. > > > Summary > ------- > > Catches, logs, and sleeps when a general exception occurs. This is similar to > PollingSourceRunner. > > > This addresses bug FLUME-984. > https://issues.apache.org/jira/browse/FLUME-984 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java ee75b54 > > flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java > 264fce1 > > Diff: https://reviews.apache.org/r/3980/diff > > > Testing > ------- > > All unit tests pass. > > > Thanks, > > Brock > >
