[
https://issues.apache.org/jira/browse/FLUME-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228134#comment-13228134
]
Juhani Connolly commented on FLUME-984:
---------------------------------------
I'm somewhat disappointed this was rushed through despite clear disagreement
without discussing the exception handling methods. While I think there is some
merit to Arvinds argument, I think it is the task of any outside developer to
read the javadoc and comply with it when developing a component.
As is, we cannot tell the difference between an error that would mean removing
from a balancing or failover pool, and one that is just a one off. Beating away
on a dead sink(especially one that makes several retries, blocking a thread) is
a waste of resources.
By specifying separate exceptions for temporary delivery problems and for more
permanent ones, we could provide a clear interface to users, while our current
implementation now leaves us wide open for bad implementations where people
just throw whatever exception and it gets more or less ignored(just a log
entry).
> SinkRunner should catch unhanded exceptions and log them like
> PollingSourceRunner
> ---------------------------------------------------------------------------------
>
> Key: FLUME-984
> URL: https://issues.apache.org/jira/browse/FLUME-984
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: v1.1.0
>
> Attachments: FLUME-984-0.patch, FLUME-984-1.patch, FLUME-984-2.patch,
> FLUME-984-4.patch
>
>
> If a Sink throws any exception but EventDeliveryException the sink will die.
> We should catch the exception, perhaps backoff a bit, and retry like
> PollingSourceRunner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
