[ 
https://issues.apache.org/jira/browse/FLUME-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229345#comment-13229345
 ] 

Arvind Prabhakar commented on FLUME-984:
----------------------------------------

@Juhani - Sorry if I came across as not being sensitive to the discussion here. 
Please re-open the Jira to continue the discussion or better still, open 
another Jira to address exception handling throughout the project.

I do feel that putting logic into exceptions is a choice that causes more 
unpredictable behavior and is hard to implement. Hence my suggestion to Brock 
to remove it. Since he updated the patch, I felt it was ready for commit.


                
> SinkRunner should catch unhanded exceptions and log them like 
> PollingSourceRunner
> ---------------------------------------------------------------------------------
>
>                 Key: FLUME-984
>                 URL: https://issues.apache.org/jira/browse/FLUME-984
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources
>    Affects Versions: v1.0.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>             Fix For: v1.1.0
>
>         Attachments: FLUME-984-0.patch, FLUME-984-1.patch, FLUME-984-2.patch, 
> FLUME-984-4.patch
>
>
> If a Sink throws any exception but EventDeliveryException the sink will die. 
> We should catch the exception, perhaps backoff a bit, and retry like 
> PollingSourceRunner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to