> On 2012-04-05 03:18:45, Brock Noland wrote: > > looks good to me, just one nit. After you address to the nit please attache > > the patch to the JIRA. > > Juhani Connolly wrote: > Done and updated the issue. > This review is against the flume-728 so can't update the review file > here, but it's just one row
Yep, I think we can just attach the patch to the JIRA since it's just a single line. - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4152/#review6704 ----------------------------------------------------------- On 2012-03-05 03:25:20, Juhani Connolly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4152/ > ----------------------------------------------------------- > > (Updated 2012-03-05 03:25:20) > > > Review request for Flume. > > > Summary > ------- > > Made custom processors possible in the same way as sink and source: the type > can represent a classname or a shorthand name from the typedef. > > > This addresses bug FLUME-1001. > https://issues.apache.org/jira/browse/FLUME-1001 > > > Diffs > ----- > > > flume-ng-core/src/test/java/org/apache/flume/sink/TestSinkProcessorFactory.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b > flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java > 10f9f4e > > Diff: https://reviews.apache.org/r/4152/diff > > > Testing > ------- > > Existing tests pass, except I'm having an issue with TestNetcatSource which > seems to be totally unrelated... It turns up on flume-728 head too, probably > something in my environment > > Added a new test to verify that processors created by shorthand name and by > full class create the same class, verifying that creation by classname also > works > > > Thanks, > > Juhani > >
