----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4152/#review7829 -----------------------------------------------------------
Ship it! +1 - Arvind On 2012-05-09 09:56:14, Juhani Connolly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4152/ > ----------------------------------------------------------- > > (Updated 2012-05-09 09:56:14) > > > Review request for Flume. > > > Summary > ------- > > Made custom processors possible in the same way as sink and source: the type > can represent a classname or a shorthand name from the typedef. > > > This addresses bug FLUME-1001. > https://issues.apache.org/jira/browse/FLUME-1001 > > > Diffs > ----- > > > flume-ng-core/src/test/java/org/apache/flume/sink/SinkProcessorFactoryTest.java > PRE-CREATION > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java > d397bd3 > flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java > 3ff6737 > > Diff: https://reviews.apache.org/r/4152/diff > > > Testing > ------- > > Existing tests pass, except I'm having an issue with TestNetcatSource which > seems to be totally unrelated... It turns up on flume-728 head too, probably > something in my environment > > Added a new test to verify that processors created by shorthand name and by > full class create the same class, verifying that creation by classname also > works > > > Thanks, > > Juhani > >
