[ 
https://issues.apache.org/jira/browse/FLUME-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254502#comment-13254502
 ] 

[email protected] commented on FLUME-1117:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4708/
-----------------------------------------------------------

(Updated 2012-04-16 04:09:32.452242)


Review request for Flume.


Changes
-------

1. Added missing callbacks per feedback from Prasad
2. Clarified interface semantics in Javadoc and made callback implementations 
consistent with it
3. Calling flush() then sync() for HDFS output (per convo w/ HDFS devs)


Summary
-------

Patch with support for Avro Container File format.


This addresses bug FLUME-1117.
    https://issues.apache.org/jira/browse/FLUME-1117


Diffs (updated)
-----

  flume-ng-core/pom.xml 37fb112 
  
flume-ng-core/src/main/java/org/apache/flume/formatter/output/EventFormatter.java
 c8b953d 
  
flume-ng-core/src/main/java/org/apache/flume/formatter/output/TextDelimitedOutputFormatter.java
 a12afd3 
  
flume-ng-core/src/main/java/org/apache/flume/serialization/AbstractAvroEventSerializer.java
 PRE-CREATION 
  
flume-ng-core/src/main/java/org/apache/flume/serialization/BodyTextEventSerializer.java
 PRE-CREATION 
  
flume-ng-core/src/main/java/org/apache/flume/serialization/EventSerializer.java 
PRE-CREATION 
  
flume-ng-core/src/main/java/org/apache/flume/serialization/EventSerializerFactory.java
 PRE-CREATION 
  
flume-ng-core/src/main/java/org/apache/flume/serialization/EventSerializerType.java
 PRE-CREATION 
  
flume-ng-core/src/main/java/org/apache/flume/serialization/FlumeEventAvroEventSerializer.java
 PRE-CREATION 
  flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java 
a2f4f66 
  
flume-ng-core/src/test/java/org/apache/flume/serialization/SyslogAvroEventSerializer.java
 PRE-CREATION 
  
flume-ng-core/src/test/java/org/apache/flume/serialization/TestBodyTextEventSerializer.java
 PRE-CREATION 
  
flume-ng-core/src/test/java/org/apache/flume/serialization/TestFlumeEventAvroEventSerializer.java
 PRE-CREATION 
  
flume-ng-core/src/test/java/org/apache/flume/serialization/TestSyslogAvroEventSerializer.java
 PRE-CREATION 
  flume-ng-core/src/test/resources/syslog_event.avsc PRE-CREATION 
  
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
 fdad75b 
  
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSCompressedDataStream.java
 c8e1df9 
  
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSDataStream.java
 39a4456 
  
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
 9f28d82 
  
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSSequenceFile.java
 49a62df 
  
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSWriter.java
 2e5470e 
  
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockHDFSWriter.java
 73d3284 
  
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java
 fb61092 
  
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java
 5a6ad47 
  pom.xml 3a9bc42 

Diff: https://reviews.apache.org/r/4708/diff


Testing
-------

Unit tests pass. New unit tests added for new functionality.


Thanks,

Mike


                
> Support output to files in Avro container format
> ------------------------------------------------
>
>                 Key: FLUME-1117
>                 URL: https://issues.apache.org/jira/browse/FLUME-1117
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.2.0
>            Reporter: Mike Percy
>            Assignee: Mike Percy
>             Fix For: v1.2.0
>
>
> Support output of events to a file in Avro container format.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to