[
https://issues.apache.org/jira/browse/FLUME-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254504#comment-13254504
]
[email protected] commented on FLUME-1117:
------------------------------------------------------
bq. On 2012-04-12 21:51:03, Prasad Mujumdar wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java,
line 224
bq. > <https://reviews.apache.org/r/4708/diff/1/?file=101449#file101449line224>
bq. >
bq. > should it call serializer flush and beforeClose here ?
Thanks for the catch! Added that.
bq. On 2012-04-12 21:51:03, Prasad Mujumdar wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java,
line 146
bq. > <https://reviews.apache.org/r/4708/diff/1/?file=101449#file101449line146>
bq. >
bq. > Do we need another outputStream flush after seriallizer.flush() ?
I've just clarified the interface contract. So yes, now outputStream.flush()
should always follow serializer.flush() in order to get durability semantics.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4708/#review6901
-----------------------------------------------------------
On 2012-04-16 04:09:32, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4708/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-16 04:09:32)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Patch with support for Avro Container File format.
bq.
bq.
bq. This addresses bug FLUME-1117.
bq. https://issues.apache.org/jira/browse/FLUME-1117
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/pom.xml 37fb112
bq.
flume-ng-core/src/main/java/org/apache/flume/formatter/output/EventFormatter.java
c8b953d
bq.
flume-ng-core/src/main/java/org/apache/flume/formatter/output/TextDelimitedOutputFormatter.java
a12afd3
bq.
flume-ng-core/src/main/java/org/apache/flume/serialization/AbstractAvroEventSerializer.java
PRE-CREATION
bq.
flume-ng-core/src/main/java/org/apache/flume/serialization/BodyTextEventSerializer.java
PRE-CREATION
bq.
flume-ng-core/src/main/java/org/apache/flume/serialization/EventSerializer.java
PRE-CREATION
bq.
flume-ng-core/src/main/java/org/apache/flume/serialization/EventSerializerFactory.java
PRE-CREATION
bq.
flume-ng-core/src/main/java/org/apache/flume/serialization/EventSerializerType.java
PRE-CREATION
bq.
flume-ng-core/src/main/java/org/apache/flume/serialization/FlumeEventAvroEventSerializer.java
PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java
a2f4f66
bq.
flume-ng-core/src/test/java/org/apache/flume/serialization/SyslogAvroEventSerializer.java
PRE-CREATION
bq.
flume-ng-core/src/test/java/org/apache/flume/serialization/TestBodyTextEventSerializer.java
PRE-CREATION
bq.
flume-ng-core/src/test/java/org/apache/flume/serialization/TestFlumeEventAvroEventSerializer.java
PRE-CREATION
bq.
flume-ng-core/src/test/java/org/apache/flume/serialization/TestSyslogAvroEventSerializer.java
PRE-CREATION
bq. flume-ng-core/src/test/resources/syslog_event.avsc PRE-CREATION
bq.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
fdad75b
bq.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSCompressedDataStream.java
c8e1df9
bq.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSDataStream.java
39a4456
bq.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
9f28d82
bq.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSSequenceFile.java
49a62df
bq.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSWriter.java
2e5470e
bq.
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockHDFSWriter.java
73d3284
bq.
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java
fb61092
bq.
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java
5a6ad47
bq. pom.xml 3a9bc42
bq.
bq. Diff: https://reviews.apache.org/r/4708/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass. New unit tests added for new functionality.
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> Support output to files in Avro container format
> ------------------------------------------------
>
> Key: FLUME-1117
> URL: https://issues.apache.org/jira/browse/FLUME-1117
> Project: Flume
> Issue Type: Improvement
> Affects Versions: v1.2.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
>
> Support output of events to a file in Avro container format.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira