Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=467729
--- Comment #25 from Frédéric Wang (:fredw) <[email protected]> 2014-11-19 23:19:19 PST --- (In reply to Karl Tomlinson (:karlt) from comment #24) > Is the topic sufficient? Could the subject be null? > That would mean that some parameters are unnecessary and could be removed. - I could do as in my previous patches and define my own XPCOM callback class, but IIUC nsIObserver seems quite standard (even when not all the parameters are used). For example in https://bugzilla.mozilla.org/attachment.cgi?id=8520633&action=diff#a/mobile/android/chrome/content/FontLocator.js_sec2 we use one "observe" function to check all the notifications. That's also the approach I've taken for the MissingFontsNotifier add-on https://github.com/fred-wang/MissingFontsNotifier/blob/master/bootstrap.js#L91 - The aSubject parameter could probably be null and so I can avoid passing it to each callback functions. However, if a caller launches two PackageKit commands using different nsIPackageKit instances, the aSubject parameter will allow to determine from which instance the callback is coming (this does not help if the same nsIPackageKit is used though). -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email ------------------------------- Product/Component: Firefox :: General ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ fonts-bugs mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
