Do not reply to this email. You can add comments to this bug at https://bugzilla.mozilla.org/show_bug.cgi?id=467729
--- Comment #32 from Frédéric Wang (:fredw) <[email protected]> 2015-02-14 04:25:53 PST --- (In reply to Karl Tomlinson (:karlt) from comment #31) > >+nsPackageKitService::Init() > >+{ > >+#define FUNC(name, type, params) { #name, (nsGDBusFunc *)&_##name }, > >+ static const nsGDBusDynamicFunction kGDBusSymbols[] = { > > I don't think there's any advantage in having the "static" here. > The function is run only once and position-independent objects mean that the > pointers can't be determined until runtime. Better I think would be to > remove > static, removing any risk of the compiler requesting additional relocations > at > start-up. As I said in comment 21, this was copied from GSettings. However, I don't see any justification for the static keyword on bug 713827. -- Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email ------------------------------- Product/Component: Firefox :: General ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ fonts-bugs mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs http://fonts.fedoraproject.org/
