Victor, Your IDE tool created another ".*" invalid import at http://cvs.apache.org/viewcvs.cgi/xml-fop/src/java/org/apache/fop/fo/extensions/svg/SVGElementMapping.java?rev=1.1&content-type=text/vnd.viewcvs-markup. Please fix it up--the Batik team is requesting changes to this file.
When I have moved classes in the past, I just do a file-wide add & search-and-replace on import statements so that no invalid imports need be created. You would be correct if you were to presume that this takes 5 mins. vs. perhaps 3 seconds for your "nice" IDE class-moving tool--problem is, trying to retroactively figure out which classes are in which file takes far more effort than the 4:57 saved. If you don't feel this way, fine, go ahead and retroactively fit all classes you created w/invalid imports to our coding standards, but from now on please make the changes *before* checking the file in. It is important that the time involved in this retrofitting be part of the calculations in your decision to use the IDE refactoring tool. Just leaving the code invalid and "hiding in the tall grass"--to use your phrase--should not be considered an option, as it would result in disasterous overuse of that IDE function. Glen <Q> > On another issue, Victor, *please* don't forget to > fully qualify the import statements -- that's one of > our coding conventions and very helpful in grokking > code -- a "import org.apache.fop.apps.*;" was added > last week in the PDFRenderer.java: Well, it isn't a matter of forgetting. I know all about it, and there are lots more than the one you point out. My IDE is doing this when it does its nice move and rename refactorings. It is even adding them in classes where they are not needed. I have also introduced many other checkstyle problems along the way, mostly missing javadoc comments for new accessor methods, etc. I'll fix them in batch mode when I can come up for air. If all of our checkstyle problems were fixed, it would be easy to just run the report before doing a commit and fix any that showed up. But there is no practical way to do this with hundreds still out there. Victor Mote </Q> __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
