Hi,

The code that I checked out this evening from CVS HEAD generates
compile errors, for example,

    [javac] 
/fsd/source/xml-fop/build/gensrc/org/apache/fop/fo/properties/BorderBottomStyleMaker.java:21:
 cannot resolve symbol
    [javac] symbol  : variable PR_BORDER_AFTER_STYLE 
    [javac] location: interface org.apache.fop.fo.properties.Constants
    [javac]         p= 
propertyList.getExplicitOrShorthand(propertyList.wmMap(Constants.PR_BORDER_AFTER_STYLE,
 Constants.PR_BORDER_AFTER_STYLE, Constants.PR_BORDER_END_STYLE));
    [javac]                                                                            
                                 ^

The cause is that the import section is not sufficient:

package org.apache.fop.fo.properties;
      
import org.apache.fop.fo.*;
import org.apache.fop.apps.FOPException;

With these import statements the compiler applies interface
org.apache.fop.fo.properties.Constants instead of interface
org.apache.fop.fo.Constants. An explicit statement

import org.apache.fop.fo.Constants;

should be added. I did it as follows:

--- properties.xsl.~1.30.~      Sat Jan 10 20:02:04 2004
+++ properties.xsl      Sat Jan 10 21:53:43 2004
@@ -329,7 +329,8 @@
 import org.apache.fop.datatypes.*;</xsl:text>
       </xsl:if>
       <xsl:text>
-import org.apache.fop.fo.*;</xsl:text>
+import org.apache.fop.fo.*;
+import org.apache.fop.fo.Constants;</xsl:text>
       <xsl:if test="not(
                     (./datatype and ./datatype[. ='List'])
                     or ./class-name[.='GenericCondPadding']
@@ -338,10 +339,6 @@
         <xsl:text>
 import org.apache.fop.apps.FOPException;</xsl:text>
       </xsl:if>
-  <xsl:if test=".//enumeration and @type='generic'">
-    <xsl:text>
-import org.apache.fop.fo.Constants;</xsl:text>
-</xsl:if>
       <xsl:text>
 
 public class </xsl:text>

The old code applies a precise test for the inclusion of the import
statement. My change includes the import statement in all property
makers. Not sure what a more precise test would look like, and if
there can be any.

Regards, Simon

-- 
Simon Pepping
email: [EMAIL PROTECTED]
home page: http://www.leverkruid.nl
public key: http://www.leverkruid.nl/personal/sp.asc
fingerprint: E3BF 7295 9AA8 8B8A C01A  219D FAAC 088C 6B28 F549

Reply via email to