DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=31162>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=31162 [PATCH] Commandline logger ------- Additional Comments From [EMAIL PROTECTED] 2004-09-11 16:43 ------- Oh, so this is what Jeremias meant. ;) Nice implementation, but would like two changes to your patch: 1.) I would like CommandLineLogger to be in the apps package, because I prefer the packages to be more standalone and separable from each other. CLL is only used by CommandLineOptions, so apps IMO is best. 2.) Having the constructor for CommandLineOptions take the args[] parameter again. I don't like the ability to create objects in an invalid state--in this case, having a CommandLineOptions object alive without having a command-line options string. So I tend to prefer constructors that require what is needed up-front--it saves validation code later. Otherwise, all looks good. +1. Glen
