DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31162>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31162

[PATCH] Commandline logger





------- Additional Comments From [EMAIL PROTECTED]  2004-09-12 18:22 -------
<Q>
2.) Having the constructor for CommandLineOptions take the args[] parameter
again.  I don't like the ability to create objects in an invalid state--in this
case, having a CommandLineOptions object alive without having a command-line
options string.  So I tend to prefer constructors that require what is needed
up-front--it saves validation code later.
</Q>

Sure, but then we need some other way of logging the exceptions thrown during
command argument parsing. Right now we get can get an exception during the
CommandLineOptions ctor. As a result the "options" vrbl is null in Fop.main()
and we are not able to output the exception to the logger which was created but
lost during the exception.

Try f.ex:

   fop -fo -pdf out

to see that no information about the exception is printed.

regards,
finn

Reply via email to